fix(knowledge): demote youtube-digest variation-matrix-backlog out of evals/fixtures - #727

Claude finished @kyle-sexton's task in 2m 26s —— View job

PR Review — fix(knowledge): demote youtube-digest variation-matrix-backlog out of evals/fixtures

• Read PR description and understand the change
• Review diff and changed files
• Check alignment with CLAUDE.md guidelines
• Verify CHANGELOG and version bump correctness
• Post review findings

Verdict: LGTM — the demote decision is well-justified and the mechanical changes are clean. One minor nit on path anchoring worth noting.

What changed

Correctness

Demote is the right call. Confirmed via evals/evals.json: no eval case has a files[] entry for variation-matrix-backlog.json. The graded fixture driver-video-goldens.json stays wired in evals 2 and 4 and is undisturbed. The moved file is demonstrably tracking data (status fields, smoke notes, blocked-caption records, alternate_blocked entries), not an input→expected-output pair.

reference/ is the correct destination. The pattern is well-established: 30+ reference/ directories exist across plugins, including plugins/knowledge/skills/course-digest/reference/. No new convention is being introduced.

Baseline cleanup is correct. The 7 removed lines are exactly the comment block + fixture path for the now-relocated file. The remaining autonomy entries (tracked by #662) are untouched.

Version bump is appropriate. Relocation + docs with no behavior change → patch-level. Consistent with how 0.7.x bumps are handled in this changelog.

Nit — TUNING.md path anchor is inconsistent with SKILL.md

vendor/video-digestion/TUNING.md line 5:

-Variation smokes in `evals/fixtures/variation-matrix-backlog.json`.
+Variation smokes in `skills/youtube-digest/reference/variation-matrix-backlog.json`.

SKILL.md line 398 uses a skill-root-relative path:

reference/variation-matrix-backlog.json

TUNING.md now uses a plugin-root-relative path (plugins/knowledge/ as the anchor). The old TUNING.md path was also skill-root-relative, and TUNING.md lives two levels away in vendor/video-digestion/ — so both forms require a mental context switch anyway. The new path is navigable and unambiguous from the plugin root. This is a minor inconsistency inherited from the pre-existing style, not introduced by this PR. Not worth blocking on.

Summary

Change is mechanically complete and correctly scoped. All cross-references updated, baseline entry cleaned, version and changelog correct. No behavioral change, no security surface, no orphan created. Ready to merge.

Post-green review pass complete (rule 8). Bot review: LGTM, demote decision confirmed correct (verified against evals.json myself: no files[] reference to the fixture), reference/ destination matches 30+ existing precedents in this repo. One nit flagged (TUNING.md path-anchor style inconsistency, pre-existing pattern not introduced by this PR) — non-blocking, not fixing.

No threads to resolve, CI fully green (17/17).

Flipping to ready for review; handing off to the babysit lane for merge.

Claude finished @kyle-sexton's task in 2m 22s —— View job

PR Review — fix(knowledge): demote youtube-digest variation-matrix-backlog out of evals/fixtures

• Read PR description and understand the change
• Review diff and changed files
• Verify demote decision against evals.json
• Check CHANGELOG and version bump correctness
• Check cross-reference updates (SKILL.md, TUNING.md)
• Verify baseline cleanup

Verdict: LGTM — demote decision is correct, all six files are mechanically clean, and no regressions introduced. One pre-existing nit on the baseline comment and one inherited path-anchor inconsistency (both carried from the first review pass), neither blocking.

Demote decision — confirmed correct

Verified against evals/evals.json: the only files[] entries across all nine eval cases reference evals/fixtures/driver-video-goldens.json (evals 2, 4, and 5). No case references variation-matrix-backlog.json. The file is demonstrably tracking data — status fields, smoke_pass notes, alternate_blocked records — not an input→expected-output pair.

The reference/ destination is correct: the relocated file is the sole entry in reference/ for this skill, consistent with the pattern used across 30+ reference/ directories in the repo.

Changed files

Nit 1 — TUNING.md path anchor (carried from first review, non-blocking)

vendor/video-digestion/TUNING.md L5 now uses a plugin-root-relative path (skills/youtube-digest/reference/…), while SKILL.md L398 uses a skill-root-relative path (reference/…). The old TUNING.md path was also skill-root-relative — the style inconsistency is pre-existing and wasn't introduced here. Both forms are navigable and unambiguous. Not worth blocking on.

Nit 2 — baseline comment starts mid-sentence (pre-existing, non-blocking)

scripts/orphaned-fixtures-baseline.txt L15 opens with # eval files[] entry and graded by no test) plus the otlp-demo sample corpus, — a sentence fragment, suggesting the preceding line(s) of this comment were removed in an earlier edit. The PR's diff only touches lines 25–31 (after the otlp-demo path entries) so this was already present before this change. Minor maintenance debt, not introduced here.

Summary

All cross-references updated, baseline entry cleanly removed, version and changelog correct. No behavioral change, no new orphan created, no security surface introduced. The orphaned-fixtures gate now passes clean with no grandfather entry remaining for the knowledge plugin. Ready to merge.